Document adapterOptions on REST adapter #7447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
approved these changes
Mar 30, 2021
|
Thank you, I fixed the linting, Will merge once CI is green |
|
Thanks @igorT I hadn't gotten to it yet 😄 Also, have you thought about joining the Github sponsorship program? We'd like to donate to some of the core Ember (and Ember Data) contributors, and you're definitely one of them. I know it's not much, but hopefully more companies will join in eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we aren't documenting adapterOptions for
queryandqueryRecordin the JSONAPIAdapter.I've just mirrored the code in the regular adapter:
https://github.com/emberjs/data/blob/master/packages/adapter/addon/index.ts#L248
There are already tests for this, see:
data/packages/-ember-data/tests/integration/adapter/store-adapter-test.js
Line 1526 in ff4f911
Support for
adapterOptionshas existed for quite a while, it was initially added in this PR: #4856